Find answers from the community

Updated 3 months ago

Implement EvalQueryEngineTool by d-maria...

Hey all! I'm working with a team that has already contributed to llama-index and even started collaborating with the team. We are super excited to have started this process and look forward to growing together.

I have created a PR that proposes a query engine tool that provides on-the-fly evaluation capabilities, where the evaluation result is then used to determine the tool output: https://github.com/run-llama/llama_index/pull/11679

I would love the team's input! Open to chatting!

7 comments

LLogan M

Thanks for the contribution! 🦙 ❤️

Will review soon!

rredfield01

Just saw your comment, but you may have deleted it. You saw a change I made that isn't required, just DRYs code out a bit. Definitely a confuse ray in that regard, so apologies if it was distracting. lmk if you still think it's a concern. Looks like existing UTs passed so we should be good though!

LLogan M

Yea I wrote a comment and then realized you just moved the code ha (should have read further down first)

LLogan M

The change makes sense to me though

rredfield01

Dope! Thanks for the review!

rredfield01

Hey @Logan M! I've added a notebook for this PR, let me know what you think here: https://github.com/run-llama/llama_index/pull/11679/files#r1520278711

rredfield01

FYI @Logan M I was able to test the notebook and produce the intended result in the end, but I hit some snags. I'm open to chatting via a zoom or something?

Add a reply