Find answers from the community

Updated 2 months ago

hey @Logan M, i have a quick question on

hey , i have a quick question on callback manager and query engine. We're trying to allow users to optionally supply a custom trace_id when running query(trace_id="...") here: https://github.com/run-llama/llama_index/blob/879d4dfdf0f02391d634088f7b51f031b95c5bc6/llama-index-core/llama_index/core/base/base_query_engine.py#L46, will you accept this change if we were to make this PR?
L
j
2 comments
Hmm. Attaching user-level data has definitely been an ask.

the existing callbacks system is in the process of getting replaced by the instrumentation system.

What I had in mind for this was instead some context manager usage
Plain Text
with dispatcher.instrument({"trace_id": "123"}):
  query_engine.query()


But, not quite there yet, probably this week πŸ™

I don't think I would accept that PR though πŸ˜… Since it only covers two entry points, and modifies a core interface. Feels like a better solution would be just keep it all contained to the callback (or, instrumenation)
I see, thanks for letting us know
Add a reply
Sign up and join the conversation on Discord