Find answers from the community

Updated last month

Add longllmlingua2 integration by titusl...

At a glance

Hello! I took a stab at sprucing up LlamaIndex's integration with llmlingua (to include integration with llmlingua2) but the linting action failed at the MakeFile xD

Not sure how to clear it - anyone got an idea?

https://github.com/run-llama/llama_index/pull/17531

15 comments

LLogan M

do you have pre-commit installed? If you do, it runs all the linting for you on commit

alternatively, you can run make lint and it should modify the files (or print errors for files it couldn't modify)

LLogan M

Thanks for adding this!

LLogan M

If you cant quite get it to work, I can push to your PR branch in a bit too

ttitus

Oops sorry! I went to bed right after 😅 I can take a look again later!

ttitus

It’s funny because I didn’t edit the MakeFile at all but the linting failed on it haha

ttitus

@Logan M I saw that you merged to main!! Does this mean I can stop working on it?

LLogan M

No, i was just fixing unrelated upstream things lol, merging main into your branch

LLogan M

Does running make lint not work for you?

ttitus

Oh lol!! Sorry! Was in meetings all morning (in Singapore). Can only work on it later! Update you when I can

ttitus

updated! Passed everything! Had to install pre-commit and then I ran make --debug lint. Thanks @Logan M!

ttitus

sorry sorry I just realized that my current code loses all the metadata within the nodes so I refactored my code a little to preserve it! it's good to go now @Logan M!

LLogan M

nice! I'll take a look today and hopefully get it merged. Thanks for the effort 🙏

ttitus

Hey @Logan M! must I update the version of the poetry file for llama-index-integrations-postprocessor-longllmlingua and push to pypi? Or this is done automatically when llama-index publishes a new release

ttitus

oh wait you did that already! I saw that the last release was 18 Jan 2025! Thanks!!

LLogan M

Yup, I snuck a commit into your PR 👍

Add a reply