Add longllmlingua2 integration by titusl...

Question

Hello! I took a stab at sprucing up LlamaIndex's integration with llmlingua (to include integration with llmlingua2) but the linting action failed at the MakeFile xD

Not sure how to clear it - anyone got an idea?

https://github.com/run-llama/llama_index/pull/17531

Logan M · Answer

do you have pre-commit installed? If you do, it runs all the linting for you on commitalternatively, you can run make lint and it should modify the files (or print errors for files it couldn't modify)

Logan M · Answer

Thanks for adding this!

Logan M · Answer

If you cant quite get it to work, I can push to your PR branch in a bit too

titus · Answer

Oops sorry! I went to bed right after 😅 I can take a look again later!

titus · Answer

It’s funny because I didn’t edit the MakeFile at all but the linting failed on it haha

titus · Answer

@Logan M I saw that you merged to main!! Does this mean I can stop working on it?

Logan M · Answer

No, i was just fixing unrelated upstream things lol, merging main into your branch

Logan M · Answer

Does running make lint not work for you?

titus · Answer

Oh lol!! Sorry! Was in meetings all morning (in Singapore). Can only work on it later! Update you when I can

titus · Answer

updated! Passed everything! Had to install pre-commit and then I ran make --debug lint. Thanks @Logan M!

titus · Answer

sorry sorry I just realized that my current code loses all the metadata within the nodes so I refactored my code a little to preserve it! it's good to go now @Logan M!

Logan M · Answer

nice! I'll take a look today and hopefully get it merged. Thanks for the effort 🙏

Find answers from the community

Add longllmlingua2 integration by titusl...